Skip to content

Add extraObjects support to the knative-operator chart - #2342

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
aqeelat:chart-extra-objects
Aug 21, 2026
Merged

Add extraObjects support to the knative-operator chart#2342
knative-prow[bot] merged 1 commit into
knative:mainfrom
aqeelat:chart-extra-objects

Conversation

@aqeelat

@aqeelat aqeelat commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Adds an optional extraObjects list to the knative-operator Helm chart. Each entry renders as a manifest alongside the operator. Empty by default — no behavior change for existing installs.

Why

Operators frequently need small platform-specific adjuncts that don't belong in the chart proper: OpenShift SCC bindings, extra RBAC, NetworkPolicies, PriorityClasses. The standard Helm extraObjects idiom (as in kube-prometheus-stack and bitnami charts) lets users keep those in the same release instead of parallel tooling.

Example:

extraObjects:
  - apiVersion: rbac.authorization.k8s.io/v1
    kind: ClusterRoleBinding
    metadata:
      name: knative-serving-nonroot-v2-scc
    roleRef:
      apiGroup: rbac.authorization.k8s.io
      kind: ClusterRole
      name: system:openshift:scc:nonroot-v2
    subjects:
      - kind: ServiceAccount
        name: default
        namespace: knative-serving

@aqeelat
Add extraObjects support to the knative-operator chart
5eefe51 
Signed-off-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

Welcome @aqeelat! It looks like this is your first PR to knative/operator 🎉

@knative-prow
knative-prow Bot requested review from aliok and kahirokunn August 19, 2026 22:23
@knative-prow knative-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2026
@knative-prow

knative-prow Bot commented Aug 19, 2026

Copy link
Copy Markdown

Hi @aqeelat. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk

dsimansk commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

IMO you have more experience with helm and charts, could you review this PR pls? Thanks! (if not feel free to un-assign)

/assign @kahirokunn

@dsimansk

dsimansk commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.99%. Comparing base (27b6123) to head (5eefe51).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          55       55           
  Lines        2491     2491           
=======================================
  Hits         1594     1594           
  Misses        777      777           
  Partials      120      120

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn

kahirokunn commented Aug 21, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution! This is a very common feature we see frequently, and several CNCF projects have already adopted it.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2026
@dsimansk

dsimansk commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow

knative-prow Bot commented Aug 21, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aqeelat, dsimansk, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2026
@knative-prow
knative-prow Bot merged commit b4f2c25 into knative:main Aug 21, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok
@kahirokunn kahirokunn Awaiting requested review from kahirokunn

Assignees

@dsimansk dsimansk

@kahirokunn kahirokunn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aqeelat @dsimansk @kahirokunn